Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixbuild help regarding --clean #9994

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Fixbuild help regarding --clean #9994

merged 1 commit into from
Jan 8, 2025

Conversation

Secrus
Copy link
Member

@Secrus Secrus commented Jan 8, 2025 •
edited by sourcery-ai bot
Loading

Resolves: #9993

Summary by Sourcery

Bug Fixes:

  • Correct the help text for the --clean option in the build command to accurately describe its behavior.

@sourcery-ai Sourcery AI
Copy link

sourcery-ai bot commented Jan 8, 2025 •
edited
Loading

Reviewer's Guide by Sourcery

This pull request fixes the help text for the --clean option in the build command. The description is now more concise and accurate.

Class diagram showing the BuildCommand class modification

classDiagram
    class BuildCommand {
        +handle()
    }
    note for BuildCommand "Modified --clean option description
from 'Clean' to 'Clean output directory before building.'"
Loading

File-Level Changes

Change Details Files
Improved the description of the --clean option in the build command's help text.
  • Changed the description of the --clean option to be more concise and accurate.
  • Removed the redundant period at the end of the description.
  • Corrected a minor grammatical error in the original description.
 src/poetry/console/commands/build.py

Possibly linked issues

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

sourcery-ai[bot]
sourcery-ai bot reviewed Jan 8, 2025
View reviewed changes
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Secrus - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good
Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@Secrus Secrus requested a review from a team January 8, 2025 10:02
@abn abn enabled auto-merge (rebase) January 8, 2025 11:46
@Secrus Secrus disabled auto-merge January 8, 2025 11:46
@Secrus Secrus enabled auto-merge (squash) January 8, 2025 11:47
@Secrus Secrus merged commit 4e8cdf0 into python-poetry:main Jan 8, 2025
73 checks passed
@radoering radoering mentioned this pull request Jan 11, 2025
Merged
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 8, 2025

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

@abn abn abn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Short --clean option for build subcommand is malformed
2 participants
@Secrus @abn